Improve validation for Acurite 896 rain gauge, set priority to 10, and re-enable by default #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d re-enable by default
|
What is the nominal count of repeats for the Acurite 896 rain gauge? Is it 12? |
16 |
|
Can you comment that before the |
andrewjw
pushed a commit
to andrewjw/rtl_433
that referenced
this pull request
Sep 29, 2023
* Improve validation for Acurite 896 rain gauge, set priority to 10, and re-enable by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have both the rain gauge and multiple Oregon sensors, which are the source of the frequent misattributions by the old Acurite 896 rain gauge code. Checking bitbuffer->num_rows clears up the issue described in #353.