-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Celsia CZC1 #2391
Conversation
Follows discussion at #2389 This decoder works, so I thought I'd start the PR with what I've got. Aside from whatever else comes up, there are two issues with it I'd appreciate direction for:
|
Remove the "type" key you have. There is no need for that info, it's either packets with "heat" or empty packets. I can rewrite the bit decoder later, basically I would use the fact that when aligned a byte will hold exactly 2 bits, i.e. it can only ever be 55, 5a, a5, aa. Otherwise using |
I've updated the code with the corrections. The decoder matches against byte values now, but I'm happy for the it to be rewritten :) |
Looks good. In the long term we might want to put the bits into a |
Co-authored-by: Liban Hannan <liban.p@gmail.com>
Initial working code