feat: Added CLI --refresh-catalog option and extractor extra use_cached_catalog to ignore the cached source catalog
#8580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com>
…ect-cli-select-service test: Add more tests for `SelectService` and the `select` command
✅ Deploy Preview for meltano canceled.
|
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/ignore-catalog-cache
branch
3 times, most recently
from
64243b6 to
6424257
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/ignore-catalog-cache
branch
from
6424257 to
d4041c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8580 +/- ##
==========================================
+ Coverage 91.83% 92.00% +0.17%
==========================================
Files 245 246 +1
Lines 19296 19369 +73
Branches 2152 3418 +1266
==========================================
+ Hits 17720 17821 +101
+ Misses 1303 1272 -31
- Partials 273 276 +3 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
requested review from
tayloramurphy,
a team and
WillDaSilva
as code owners
WillDaSilva
reviewed
Jun 17, 2024
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/ignore-catalog-cache
branch
from
b933cf5 to
04432bd
Compare
edgarrmondragon
changed the title
--refresh-catalog option and use_cached_catalog extractor extra to allow ignore the cached source catalog
edgarrmondragon
changed the title
--refresh-catalog option and use_cached_catalog extractor extra to allow ignore the cached source catalog--refresh-catalog option and extractor extra use_cached_catalog to ignore the cached source catalog
WillDaSilva
approved these changes
Jun 17, 2024
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6919
no_catalog_cacheuse_cached_catalogto config extras, so that a single plugin can be run every time without the catalog cache.--catalog-refresh--refresh-catalogoption tomeltano selectandmeltano elAdding a new extra seems extreme, but I don't know how else to implement this where it could be used as part of a job for any tap. If there's a better way to do it, I'm happy to adjust this based on feedback.
Supersedes #8518