-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computer handlers generated by annotation processor #7829
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uter helper. Breaks a couple of methods to old computer code where plain Object was returned
pupnewfster
reviewed
Aug 25, 2023
src/main/java/mekanism/common/integration/computer/FactoryRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/mekanism/common/integration/computer/FactoryRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/mekanism/common/integration/computer/FactoryRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/mekanism/common/integration/computer/FactoryRegistry.java
Outdated
Show resolved
Hide resolved
annotation-processor/src/main/java/mekanism/AnnotationParamScanner.java
Outdated
Show resolved
Hide resolved
src/main/java/mekanism/common/integration/computer/computercraft/MekanismPeripheral.java
Outdated
Show resolved
Hide resolved
src/main/java/mekanism/common/integration/computer/computercraft/CCMethodCaller.java
Outdated
Show resolved
Hide resolved
src/main/java/mekanism/common/integration/computer/computercraft/CCMethodCaller.java
Outdated
Show resolved
Hide resolved
src/main/java/mekanism/common/integration/computer/opencomputers2/MekanismDevice.java
Outdated
Show resolved
Hide resolved
…services generated by the annotation processor
… it is only used by the datagen
…ff from the gitignore and build.gradle
pupnewfster
reviewed
Aug 29, 2023
src/main/java/mekanism/common/integration/computer/ComputerMethodFactory.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
@ComputerMethod
methods must now not be privateObject
-Convertable
created for the edge cases that need it