Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): Use query relation load strategy on Carts #3984

Merged
merged 8 commits into from
May 2, 2023
Merged

feat(medusa): Use query relation load strategy on Carts #3984

merged 8 commits into from
May 2, 2023

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 82ff086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@medusajs/medusa Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 6:22pm

@olivermrbl olivermrbl marked this pull request as ready for review May 2, 2023 15:43
@olivermrbl olivermrbl requested a review from a team as a code owner May 2, 2023 15:43
adrien2p
adrien2p approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrien2p
Copy link
Member

adrien2p commented May 2, 2023

LGTM

Just need the CI to pass

@olivermrbl olivermrbl changed the title feat(medusa): Default to query relation load strategy feat(medusa): Use query relation load strategy on Carts May 2, 2023
@olivermrbl olivermrbl requested a review from adrien2p May 2, 2023 17:42
@olivermrbl
Copy link
Contributor Author

Can I merge this @adrien2p ?

adrien2p
adrien2p approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, one question though, should we also do the same for the find? Otherwise it might break someone listing the carts right?

@olivermrbl
Copy link
Contributor Author

olivermrbl commented May 2, 2023 •
edited
Loading

@adrien2p – we don't support listing carts, so it could only happen if someone extended their setup with that functionality. Sorry, we do at the service level but not in the API.

Still, it wont break but just be less performant as it would use the join strategy. Think it's fine no?

@olivermrbl
Copy link
Contributor Author

In any case, we could do it in a follow-up iteration

@olivermrbl olivermrbl merged commit b7a7826 into develop May 2, 2023
@olivermrbl olivermrbl deleted the chore/update-query-strategy branch May 2, 2023 19:10
@github-actions github-actions bot mentioned this pull request May 2, 2023
Merged
@adrien2p
Copy link
Member

adrien2p commented May 2, 2023

@adrien2p – we don't support listing carts, so it could only happen if someone extended their setup with that functionality. Sorry, we do at the service level but not in the API.

Still, it wont break but just be less performant as it would use the join strategy. Think it's fine no?

@olivermrbl We can do it in a followup pr but now if someone use the list cart then the payment sessions won’t be available on the carts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@riqwan riqwan Awaiting requested review from riqwan

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivermrbl @adrien2p