Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mdx-js/mdx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.1.4
Choose a base ref
...
head repository: mdx-js/mdx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.1.5
Choose a head ref
  • 4 commits
  • 16 files changed
  • 4 contributors

Commits on Oct 7, 2022

  1. Fix casing of babel option in getting-started.server.mdx

    Closes GH-2148.
    
    Reviewed-by: Titus Wormer <tituswormer@gmail.com>
    kochie authored Oct 7, 2022
    1 Configuration menu
    Copy the full SHA
    c3ccee4 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    8970e21 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Fix bug with (injected) custom elements and layouts

    This fixes a bug, uncovered in #2112 and in #2123,
    which is rather unlikely to occur.
    It only occurs when:
    
    1.  Custom elements (such as `<a-b></a-b>`) are injected (not authored)
        into a tree
    2.  Either:
        1.  A layout component is defined within an MDX document
        2.  A provider is used, and any component is defined within MDX
            documents
    
    In those cases, an accidental `const ;` was injected into the final
    serialized document.
    Which caused anything trying to run the code to crash.
    
    The problem was introduced in 9904838, the commit message of which
    sheds some light on why custom elements are peculiar and need extra
    handling.
    
    We track which component contains which other components.
    If some component uses `<A />`, then some code to handle `A` is
    injected in that component.
    If a different component uses `<B />`, some code for `B` is injected
    inside it.
    But the components don’t need to know about what’s used in other
    components.
    
    This mechanism had a mistake for custom elements: they were tracked
    globally.
    This commit fixes that, by tracking them scoped to the component that
    includes them.
    
    Related-to: GH-2100.
    Related-to: GH-2101.
    
    Closes GH-2112.
    Closes GH-2123.
    
    Co-authored-by: Caleb Eby <caleb.eby01@gmail.com>
    Co-authored-by: bholmesdev <hey@bholmes.dev>
    3 people committed Oct 11, 2022
    1 Configuration menu
    Copy the full SHA
    90fa493 View commit details
    Browse the repository at this point in the history
  2. 2.1.5

    wooorm committed Oct 11, 2022
    1 Configuration menu
    Copy the full SHA
    6303aa2 View commit details
    Browse the repository at this point in the history
Loading