Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lifecycle-callbacks: Simplified updateStyle() #19

Merged
merged 1 commit into from
Apr 11, 2019
Merged

lifecycle-callbacks: Simplified updateStyle() #19

merged 1 commit into from
Apr 11, 2019

Conversation

brunoais
Copy link
Contributor

Instead of all that getting child nodes and then searching to see which one is the <style> tag,
just use querySelector().

@brunoais
lifecycle-callbacks: Simplified updateStyle()
3bf4d03 
Instead of all that getting child nodes and then searching to see which one is the <style> tag,
just use querySelector().
@chrisdavidmills chrisdavidmills merged commit 76ba16b into mdn:master Apr 11, 2019
@chrisdavidmills
Copy link
Contributor

Makes sense - thanks!

@brunoais
Copy link
Contributor Author

Ur welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoais @chrisdavidmills