This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
bug 1395745: add endpoint for serving revision hash #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2017
|
The Travis build will fail until mdn/kuma#4399 is merged. |
jwhitlock
approved these changes
Sep 5, 2017
| it('Revision endpoint returns git commit hash', function (done) { | ||
| testRequest(getURL('/revision'), done, function (resp, result) { | ||
| assert.equal(resp.statusCode, 200); | ||
| assert.equal(result, process.env.REVISION_HASH); |
There was a problem hiding this comment.
I get the string "undefined" back from the server, and the JS constant (?) undefined for process.env.REVISION_HASH. If you force to a string, the test passes:
assert.equal(result, '' + process.env.REVISION_HASH);
Or, we could wait for PR 4399, and make sure it passes.
jwhitlock
added a commit
to mdn/kuma
that referenced
this pull request
Sep 7, 2017
* mdn/kumascript#296 - SpecName, spec2: Add Paint Timing * mdn/kumascript#297 - SpecName: User Timing Level 2 display name * mdn/kumascript#298 - InterfaceData.json: Add Performance interfaces * mdn/kumascript#302 - SpecName, spec2: Add MediaStreamTrackHint * mdn/kumascript#303 - Endpoint for serving the revision hash * mdn/kumascript#305 - Compat: Dont check __compat for features w/o it
jwhitlock
added a commit
to mdn/kuma
that referenced
this pull request
Sep 11, 2017
* mdn/kumascript#303 - EmbedInteractiveExamples: Set IE server from env
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
/revisionendpoint and associated test. It depends on mdn/kuma#4399. The endpoint returns the value of the environment variableREVISION_HASH, the git commit hash of HEAD baked into the kumascript Docker image at the time of the build.