This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
bug 1340342: Build and test kumascript as a submodule of kuma #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checkout kumascript branches as a submodule of the kuma project, and use the kuma make targets to build and push kumascript images. This allows locales to be included in the images.
In order to include the locales in the kumascript image, build it one level up in the kuma project.
jwhitlock
force-pushed
the
build-with-locales-1340342
branch
6 times, most recently
from
9fb6979 to
066b4ed
Compare
Checkout the kuma master branch, add the target kumascript branch as the submodule, and build the docker image inside kuma.
jwhitlock
force-pushed
the
build-with-locales-1340342
branch
from
066b4ed to
998d9e5
Compare
jwhitlock
commented
Aug 31, 2017
Jenkinsfile
Outdated
| } | ||
| } | ||
|
|
||
| stage('Push KumaScript Docker Image') { | ||
| sh 'make push VERSION=latest' | ||
| sh 'echo make push-kumascript VERSION=latest' |
There was a problem hiding this comment.
I think I added echo for testing, I need to remove this from the PR
escattone
approved these changes
Aug 31, 2017
There was a problem hiding this comment.
This looks great, thanks @jwhitlock! Thanks as well for your careful update of the README.md. Feel free to merge after removing the echo in the Jenkinsfile.
|
@jwhitlock, actually let me remove that |
jwhitlock
added a commit
to jwhitlock/kuma
that referenced
this pull request
Sep 5, 2017
* mdn/kumascript#283 - Build Docker image as submodule * mdn/kumascript#292 - SpecName, spec2: Add ARIA, ARIA in HTML * mdn/kumascript#295 - GroupData, SpecName, spec2: Basic Card Payment * mdn/kumascript#301 - Fix api-test for require()
jwhitlock
added a commit
to mdn/kuma
that referenced
this pull request
Sep 5, 2017
* mdn/kumascript#283 - Build Docker image as submodule * mdn/kumascript#292 - SpecName, spec2: Add ARIA, ARIA in HTML * mdn/kumascript#295 - GroupData, SpecName, spec2: Basic Card Payment * mdn/kumascript#301 - Fix api-test for require()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkout the master branch of kuma, and the requested branch of kumascript as a submodule. Use the docker image defined in the kuma project to build and test KumaScript.
Also removes the unused make targets
deis-pull,push-private-registry, etc.Requires mdn/kuma#4362 before merging.