Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link to Wikipedia in Web/API/HTMLAnchorElement/hash #34575

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Update link to Wikipedia in Web/API/HTMLAnchorElement/hash #34575

merged 2 commits into from
Jul 3, 2024

Conversation

leon-win
Copy link
Member

@leon-win leon-win commented Jul 3, 2024

Description

Ths PR updates link to Wikipedia in Web/API/HTMLAnchorElement/hash: https://en.wikipedia.org/wiki/URL_encoding was changed to https://en.wikipedia.org/wiki/Percent-encoding

Additional details

Also updates formatting and improves example style.

@leon-win leon-win requested a review from a team as a code owner July 3, 2024 00:05
@leon-win leon-win requested review from Elchi3 and removed request for a team July 3, 2024 00:05
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-07-03 00:57:01)

@leon-win leon-win mentioned this pull request Jul 3, 2024
Merged
@leon-win @Josh-Cena
improve encoding name
6aeda3b 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Josh-Cena
Josh-Cena approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Josh-Cena Josh-Cena merged commit 3e30146 into mdn:main Jul 3, 2024
8 checks passed
@leon-win leon-win deleted the improve/web-api-htmlanchorelement-hash branch July 3, 2024 15:35
@leon-win leon-win mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leon-win @Josh-Cena