-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ValidityState docs #26431
Update ValidityState docs #26431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jean-Yves! Some work to do here.
Hey @teoli2003 - do you plan to come back to this one? |
Yes, but never get to the top of my notification list. I really need to block a day for "finish what is open". |
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Hi! Yes I'd need a reviewer. |
Assigned myself so I don't forget. I'll take a look through soon 👀 |
@bsmth @teoli2003 bumping to the top of your notifications list ;) |
Thanks, I've started and then put this off a few times but I'll try to look again today 😄 |
@teoli2003 some comments for you to have a look at 👀 back over to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made this comment a while ago, but never submitted it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Going to merge this one now to get these long-standing improvements in!
Description
Adds missing pages for:
ValidityState.customError
ValidityState.valid
Motivation
Part of openwebdocs/project#153
Additional details
I also did minor fixes to the other
ValidityState
pages to bring them closer to the current standard. (I didn't work on extra examples there, though)Related issues and pull requests
BCD PR (to fix
mdn_url
entries): mdn/browser-compat-data#19500Fixes #26522