Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ValidityState docs #26431

Merged
merged 28 commits into from
Jul 15, 2024
Merged

Update ValidityState docs #26431

merged 28 commits into from
Jul 15, 2024

Conversation

teoli2003
Copy link
Member

@teoli2003 teoli2003 commented Apr 26, 2023 •
edited

Description

Adds missing pages for:

  • ValidityState.customError
  • ValidityState.valid

Motivation

Part of openwebdocs/project#153

Additional details

I also did minor fixes to the other ValidityState pages to bring them closer to the current standard. (I didn't work on extra examples there, though)

Related issues and pull requests

BCD PR (to fix mdn_url entries): mdn/browser-compat-data#19500
Fixes #26522

@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited

Preview URLs (12 pages)

(comment last updated: 2024-07-15 15:41:31)

@teoli2003 teoli2003 marked this pull request as ready for review April 26, 2023 10:42
@teoli2003 teoli2003 requested a review from a team as a code owner April 26, 2023 10:42
@teoli2003 teoli2003 requested review from wbamberg and Elchi3 and removed request for a team and wbamberg April 26, 2023 10:42
@teoli2003 teoli2003 mentioned this pull request Apr 26, 2023
Merged
Elchi3
Elchi3 previously requested changes Apr 26, 2023
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jean-Yves! Some work to do here.

files/en-us/web/api/validitystate/valid/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/validitystate/valid/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/validitystate/valid/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/validitystate/customerror/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/validitystate/customerror/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/validitystate/customerror/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/validitystate/customerror/index.md Outdated Show resolved Hide resolved
@teoli2003 teoli2003 mentioned this pull request May 2, 2023
Closed
@bsmth bsmth added the awaiting response Awaiting for author to address review/feedback label Nov 13, 2023
@bsmth
Copy link
Member

bsmth commented Nov 30, 2023

Hey @teoli2003 - do you plan to come back to this one?

@teoli2003
Copy link
Member Author

Yes, but never get to the top of my notification list. I really need to block a day for "finish what is open".

teoli2003 and others added 4 commits December 20, 2023 13:33
@teoli2003
Merge branch 'main' into validitystate
999d073
@teoli2003 @Elchi3
Update files/en-us/web/api/validitystate/valid/index.md
0f85569 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@teoli2003 @Elchi3
Update files/en-us/web/api/validitystate/valid/index.md
3e67113 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@teoli2003 @Elchi3
Update files/en-us/web/api/validitystate/valid/index.md
cc50680 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
teoli2003 and others added 4 commits December 20, 2023 13:35
@teoli2003 @Elchi3
Update files/en-us/web/api/validitystate/customerror/index.md
e44456c 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@teoli2003 @github-actions
Update files/en-us/web/api/validitystate/customerror/index.md
c14e74c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@teoli2003
Merge branch 'validitystate' of github.com:teoli2003/content into val…
0d49694 
…iditystate
@teoli2003
Add labels to input boxes
5ff1189
@teoli2003
Copy link
Member Author

Hi! Yes I'd need a reviewer.

@bsmth bsmth removed the awaiting response Awaiting for author to address review/feedback label May 14, 2024
@bsmth bsmth self-assigned this May 14, 2024
@bsmth
Copy link
Member

bsmth commented May 14, 2024

Assigned myself so I don't forget. I'll take a look through soon 👀

@estelle
Copy link
Member

estelle commented Jun 18, 2024

@bsmth @teoli2003 bumping to the top of your notifications list ;)

@bsmth
Copy link
Member

bsmth commented Jun 21, 2024

@bsmth @teoli2003 bumping to the top of your notifications list ;)

Thanks, I've started and then put this off a few times but I'll try to look again today 😄

@bsmth
Copy link
Member

bsmth commented Jun 21, 2024

@teoli2003 some comments for you to have a look at 👀 back over to you!

@bsmth bsmth added the awaiting response Awaiting for author to address review/feedback label Jun 25, 2024
estelle
estelle reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made this comment a while ago, but never submitted it.

files/en-us/web/api/validitystate/customerror/index.md Outdated Show resolved Hide resolved
@Josh-Cena
Copy link
Member

@bsmth are you championing this PR, or is @estelle doing it?

@bsmth
Copy link
Member

bsmth commented Jul 15, 2024 •
edited

@bsmth are you championing this PR, or is @estelle doing it?

I'm fine with self-assigning it to get it over the finish line. Is that okay @estelle? I'm going to apply the suggestions shortly.

edit: I'm already assigned 😅, I'll take this one

@bsmth bsmth dismissed Elchi3’s stale review July 15, 2024 10:33

review comments are stale

@github-actions github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Jul 15, 2024
bsmth
bsmth approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Going to merge this one now to get these long-standing improvements in!

@bsmth bsmth merged commit e8805a6 into mdn:main Jul 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle left review comments

@github-actions GitHub Actions github-actions left review comments

@bsmth bsmth bsmth approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3

Assignees

@bsmth bsmth

Labels
awaiting response Awaiting for author to address review/feedback Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidityState broken link to customError
6 participants
@teoli2003 @bsmth @estelle @Josh-Cena @Elchi3 @queengooborg