Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Updating contributing guide and codespaces configuration #741

Merged
merged 72 commits into from
Sep 30, 2024

Conversation

antonymilne
Copy link
Contributor

@antonymilne antonymilne commented Sep 24, 2024

Description

I'd like reviews here from @stichbury and @maxschulz-COL please 🙏 And then when it's published let's make sure everyone on the team reads the new guide.

In preparation for GHC, but also long overdue and something I've wanted to do for ages... I think we may have a ticket about this somewhere that we can hopefully now close @stichbury?

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@antonymilne antonymilne changed the base branch from main to tidy/contribution-flow September 24, 2024 23:04
Base automatically changed from tidy/contribution-flow to main September 25, 2024 09:43
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve now pending the open comments 💪

@lingyielia lingyielia self-requested a review September 30, 2024 12:41
@antonymilne antonymilne enabled auto-merge (squash) September 30, 2024 13:24
@antonymilne antonymilne merged commit d609ba0 into main Sep 30, 2024
33 of 34 checks passed
@antonymilne antonymilne deleted the docs/contribution-flow branch September 30, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants