Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release linting #55

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Fix release linting #55

merged 3 commits into from
Sep 22, 2023

Conversation

maxschulz-COL
Copy link
Contributor

Description

  • avoid early exit from release hatch command
  • similar fix for automatic PR raised

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added the PR number to the change description in the changelog fragment, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1)) (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

lingyielia
lingyielia previously approved these changes Sep 22, 2023
View reviewed changes
@maxschulz-COL maxschulz-COL enabled auto-merge (squash) September 22, 2023 14:39
@maxschulz-COL maxschulz-COL merged commit 5c11da3 into main Sep 22, 2023
@maxschulz-COL maxschulz-COL deleted the bug/fix_linting_release branch September 22, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anna-Xiong Anna-Xiong Anna-Xiong approved these changes

@huong-li-nguyen huong-li-nguyen huong-li-nguyen approved these changes

@l0uden l0uden Awaiting requested review from l0uden

@chiara-sophie chiara-sophie Awaiting requested review from chiara-sophie

@petar-qb petar-qb Awaiting requested review from petar-qb

@nadijagraca nadijagraca Awaiting requested review from nadijagraca

@lingyielia lingyielia Awaiting requested review from lingyielia lingyielia is a code owner

Assignees
No one assigned
Labels
Bug Report 🐛 Issue contains a bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxschulz-COL @lingyielia @huong-li-nguyen @Anna-Xiong