-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Github tests trigger for CircleCI #484
Conversation
for more information, see https://pre-commit.ci
…to ci/move_ci_trigger_to_github
for more information, see https://pre-commit.ci
…to ci/move_ci_trigger_to_github # Conflicts: # .github/workflows/circleci-trigger.yml
for more information, see https://pre-commit.ci
…to ci/move_ci_trigger_to_github # Conflicts: # .github/workflows/circleci-trigger.yml
for more information, see https://pre-commit.ci
…to ci/move_ci_trigger_to_github
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…to ci/move_ci_trigger_to_github
…_ci_trigger_to_github
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for all your work on this @l0uden.
I made a few small commits just to make it more consistent with how we do other GHA on this repo:
- Small renaming - not important
- Remove remaining references to tag and unnecessary arguments - this one is the only bit that changes functionality. I think when you removed the
tag
stuff you forgot to remove some parts, so please check this - Tiny refactor - not important
If you're happy I didn't break anything here then I'm happy for you to merge whenever. I just did a quick test and it seems to work ok.
…_ci_trigger_to_github
…_ci_trigger_to_github
Description
Here we'll get rid of CircleCI pipeline for vizro repo.
New GitHub Action will trigger tests pipeline instead.
test-integration-vizro-ai
andCircleCI tests trigger
GitHub Actions will always pass for the forked repos.test-integration-vizro-ai
will run for every push tovizro-ai
folder exceptdocs
. And will run for every merge tomain
for changes in any folder.Connected with https://github.com/mckinsey/vizro-qa/pull/89
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":