Tidy hidden Div
s and default values
#188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No change to functionality; just a small tidy. Seems a bit pointless, but it will make it easier to clean up some tests in a following PR...
None
overhtml.Div(hidden=True)
in the case that we don't need to refer to the element in any way (basically whenever you don't set anid
). e.g.html.P(self.title) if self.title else None
html.Div(hidden=True)
overNone
in the case that we do need to refer to the element (basically when you do set anid
). e.g.html.Div(hidden=True, id="nav_panel_outer")
. Generally these can be identified by the fact thatbuild
return values have a type like_NavBuildType
""
as default value for optional fields which arestr
. These fields do not need to acceptNone
values at allChecklist
Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":