Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand EditCellColumnDef properties #2290

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Expand EditCellColumnDef properties #2290

merged 1 commit into from
Aug 23, 2020

Conversation

kkirsche
Copy link
Contributor

@kkirsche kkirsche commented Aug 6, 2020

Related Issue

N/A

Description

This PR expands the type definitions of the EditCellColumnDef to ensure that they capture the different information found on the tableData section of the definition which is useful while implementing a custom row editing function.

Related PRs

N/A

Impacted Areas in Application

Typescript definitions

Additional Notes

You rock, thanks for the great product and for allowing me to contribute and help improve the tool

This PR expands the type definitions of the EditCellColumnDef to ensure that they capture the different information found on the `tableData` section of the definition which is useful while implementing a custom row editing function.
@kkirsche kkirsche requested a review from mbrn as a code owner August 6, 2020 14:35
Copy link
Owner

@mbrn mbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mbrn mbrn merged commit 6b2e168 into mbrn:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants