Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 10 support #12

Closed
Treggats opened this issue Mar 16, 2023 · 5 comments
Closed

Laravel 10 support #12

Treggats opened this issue Mar 16, 2023 · 5 comments

Comments

@Treggats
Copy link
Collaborator

Hi, I'm going to work to get Laravel 10 support for this package. I'm going to use this issue to ask question and get early feedback.

At the moment I have these questions;

  • what is the minimal PHP version you want to support?
    As Laravel 10 requires at minimum PHP 8.1
  • what is the minimal Laravel version that you want to support?

I'm probably going to make a few other pull requests with additional changes, but will add questions about those here in this issue.
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
remove lock file
91a67a8 
a lock file doesn't belong in a package

issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
install php-cs-fixer
516df07 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
update config for php-cs-fixer
5339e10 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
whitespace cs fix
8eef5bb 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
not operator cs fix
9fe73fc 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
simplify Github Action for tests
5c4d28c 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add Github Action for quality check and automatic formatting
f347bbc 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add Github Action for quality check and automatic formatting
9d26c65 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
let the whole matrix run
9ae2eab 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add Github Action for quality check and automatic formatting
a3becea 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
let the whole matrix run
6c8dc0e 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add phpstan config
2e00fad 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add Github Action for quality check and automatic formatting
5e4642f 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
let the whole matrix run
5d2ac11 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add phpstan config
56d8f09 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
remove lock file
a40a26c 
a lock file doesn't belong in a package

issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
install php-cs-fixer
5caa5d1 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
update config for php-cs-fixer
f0e354d 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
whitespace cs fix
f9cf548 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
not operator cs fix
d79a6ed 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
simplify Github Action for tests
28d527b 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add Github Action for quality check and automatic formatting
332680b 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
let the whole matrix run
f1b1ed6 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add phpstan config
e23e126 
issue mazedlx#12
@Treggats Treggats mentioned this issue Mar 17, 2023
Merged
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
remove the need for composer install
b2f551d 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
run phpstan with the supported PHP versions
fe1f26e 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
remove the need for composer install
c1fb66f 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
run phpstan with the supported PHP versions
8310b75 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
remove the need for composer install
6b57119 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
run phpstan with the supported PHP versions
4870cbf 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
remove PAT secret
ef1b2cf 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add Github Action for quality check and automatic formatting
89a7995 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
let the whole matrix run
e065b3b 
issue mazedlx#12
Treggats pushed a commit to Treggats/laravel-feature-policy that referenced this issue Mar 17, 2023
add phpstan config
72243b2 
issue mazedlx#12
@Treggats
Copy link
Collaborator Author

Treggats commented Mar 18, 2023 •
edited
Loading

@mazedlx what's the best / preferred way to test this in a Laravel 10 application?

Currently I have a Laravel 10 application, with my fork installed and the middleware is added to the middlewareGroups.

A curl -i -I <site url> returns the headers listed below. Locally, on macOS and using Laravel Valet.

Returned headers 
HTTP/1.1 200 OK
Server: nginx/1.23.2
Content-Type: text/html; charset=UTF-8
Connection: keep-alive
Vary: Accept-Encoding
X-Powered-By: PHP/8.1.13
Cache-Control: no-cache, private
Date: Sat, 18 Mar 2023 14:22:25 GMT
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
Referrer-Policy: strict-origin-when-cross-origin
X-Content-Type-Options: nosniff
Permissions-Policy: geolocation=self,fullscreen=self

@mazedlx
Copy link
Owner

mazedlx commented Mar 18, 2023

There are tests in the test folder. You could make use of the Http Fake.

@Treggats
Copy link
Collaborator Author

@mazedlx would you be ok as to create a release? I think it's Laravel 10 ready, but I'd like to try it out in our own application. Which is almost ready to upgrade to Laravel 10

@mazedlx
Copy link
Owner

mazedlx commented Mar 22, 2023

I've just released v2.0

@Treggats
Copy link
Collaborator Author

Closing, as we now have Laravel 10 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Treggats @mazedlx