Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions of github actions, golangci-lint, and Go #2844

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

wiggin77
Copy link
Contributor

@wiggin77 wiggin77 commented Apr 19, 2022

Summary

  • version numbers for Github actions bumped to latest stable
  • version of golangci-lint bumped to latest stable
  • Go version bumped to 18.1 for compiling within CI.

Plugin has not been getting linted correctly for a while, but failing silently. I could not get this working via github actions after many tries. Instead I refactored the linter script to use the makefile instead of GH action. Downside, we won't get the nice inline errors in the Files changed view. Upside, it works for server and plugin and linter errors are reported. Errors appear in the CI log like:

Error: server/plugin_test.go:29:2: b declared but not used (typecheck)
	b := assert.Equal("Hello, world!", bodyString)
	^

Ticket Link

NONE

@wiggin77 wiggin77 requested a review from a team as a code owner April 19, 2022 16:11
@wiggin77 wiggin77 requested review from jespino, Rajat-Dabade, sbishel and chenilim and removed request for a team, jespino and Rajat-Dabade April 19, 2022 16:11
@wiggin77 wiggin77 added the 2: Dev Review Requires review by a core committer label Apr 19, 2022
Copy link
Collaborator

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Lint not working.

@wiggin77 wiggin77 requested a review from sbishel April 19, 2022 22:56
Copy link
Collaborator

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chenilim chenilim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Definitely odd (and scary) that the golangci-lint action would fail silently like that.

@wiggin77 wiggin77 merged commit 979807a into mattermost-community:main Apr 20, 2022
@wiggin77 wiggin77 deleted the bump_ci_versions branch April 20, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants