This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Add System to Nickname Blacklist #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
How about first/last name? |
|
Out of scope for this PR, it's certainly a valid concern @jasonblais. Currently all blacklists just apply to the username according to my understanding. |
jasonblais
requested review from
crspeller,
hmhealey and
grundleborg
and removed request for
hmhealey
grundleborg
approved these changes
Jul 12, 2018
crspeller
approved these changes
Jul 12, 2018
amyblais
added
Changelog/Done
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is related to the Server PR linked below and introduces system as a blacklisted username.
Ticket Link
N/A -> mattermost/mattermost#9060
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed