refactor(prover): Switch prover workspace to workspace deps #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilLuta
reviewed
Mar 25, 2024
There was a problem hiding this comment.
I'm super excited with these changes. Thanks for going through! There are a bunch of "unpinned" crates that make me feel uneasy (circuit_definitions, shivini, zkevm_test_harness/1_3_3). I know from crypto side that commits might be pushed on top of the branch, which would result in us potentially running code we're not intending. Any thoughts on that? (Yeah, the .lock should protect us from that, but an update to the .lock for a dependency might have nefarious updates bundled in)
EmilLuta
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Prover follow-up to #1485
Why ❔
Same reasons
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.