refactor: Switch core workspace to using workspace deps #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
force-pushed
the
popzxc-workspace-deps
branch
from
d78dcb9 to
f9ae782
Compare
montekki
approved these changes
Mar 25, 2024
perekopskiy
approved these changes
Mar 25, 2024
Artemka374
approved these changes
Mar 25, 2024
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
## What ❔ Prover follow-up to #1485 ## Why ❔ Same reasons ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Switches core workspace to using workspace deps.
During review, please focus on the fact that this should be an incremental improvement. This PR was painful to prepare, and I would like to merge it ASAP, since it's also likely to get merge conflicts. If there are non-critical comments, I'll try to address them in follow-up PRs. I've touched a lot of code that was in imperfect state before, and now it's in the diff (for example, incorrectly set features for crates), and maybe some things I've done aren't as pretty as they can be -- but IMHO the switch to using workspace deps has enough value to merge it without addressing all and every minor thing beforehand.
Feel free to leave as many comments as you have to, but it'd be great if they will still come with a ✅ unless I really broke something here.
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.