-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(genesis): Using genesis config only during the genesis #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
changed the base branch from
main
to
deniallugo-fixes-for-zk-toolbox
March 13, 2024 15:19
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
changed the base branch from
deniallugo-fixes-for-zk-toolbox
to
main
March 14, 2024 07:36
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-genesis-config
branch
from
March 15, 2024 08:57
3e6cae3
to
3842bd2
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-genesis-config
branch
from
March 15, 2024 16:22
7576b23
to
6b8fc07
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-genesis-config
branch
from
March 20, 2024 20:09
6e4543b
to
32f4bd3
Compare
Deniallugo
commented
Mar 20, 2024
Deniallugo
force-pushed
the
deniallugo-genesis-config
branch
from
March 20, 2024 20:31
32f4bd3
to
4228257
Compare
And now I've realized i can't remove verifier field from api, I'll keep it as is, and remove only from configs |
Deniallugo
force-pushed
the
deniallugo-genesis-config
branch
from
March 24, 2024 17:48
4228257
to
5cdc25e
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-genesis-config
branch
3 times, most recently
from
March 24, 2024 20:54
e1f53e8
to
81978a1
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-genesis-config
branch
from
March 24, 2024 21:16
81978a1
to
5b9982b
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-genesis-config
branch
from
March 25, 2024 10:28
44e4991
to
40839e1
Compare
perekopskiy
approved these changes
Mar 25, 2024
montekki
approved these changes
Mar 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Mar 25, 2024
RomanBrodetski
pushed a commit
that referenced
this pull request
Mar 28, 2024
🤖 I have created a release *beep* *boop* --- ## [22.1.0](core-v22.0.0...core-v22.1.0) (2024-03-28) ### Features * Drop prover tables in core database ([#1436](#1436)) ([0d78122](0d78122)) * **en:** consistency checker persistent cursor ([#1466](#1466)) ([03496e6](03496e6)) * **en:** Make snapshot syncing future-proof ([#1441](#1441)) ([8c26a7a](8c26a7a)) * **genesis:** Using genesis config only during the genesis ([#1423](#1423)) ([4b634fd](4b634fd)) * **node_framework:** Add a task to handle sigint ([#1471](#1471)) ([2ba6527](2ba6527)) * **node-framework:** Add circuit breaker checker layer to framework ([#1452](#1452)) ([2c7a6bf](2c7a6bf)) * **prover:** export prover traces through OTLP ([#1427](#1427)) ([16dce75](16dce75)) * sigint initialization only after snapshots is applied ([#1356](#1356)) ([c7c7356](c7c7356)) * Split witness generator timeout configs by round ([#1505](#1505)) ([8074d01](8074d01)) * **state-keeper:** implement asynchronous RocksDB cache ([#1256](#1256)) ([da41f63](da41f63)) * **state-keeper:** Refactor persistence in `StateKeeper` ([#1411](#1411)) ([e26091a](e26091a)) * **state-keeper:** Remove `WitnessBlockState` generation from state keeper ([#1507](#1507)) ([8ae0355](8ae0355)) * Switch contract verification API to axum and get rid of actix-web usage ([#1467](#1467)) ([e7a9d61](e7a9d61)) ### Bug Fixes * **api:** `filters_disabled` should only affect HTTP endpoints ([#1493](#1493)) ([8720568](8720568)) * **api:** Fix API server shutdown flow ([#1425](#1425)) ([780f6b0](780f6b0)) * **prover:** Remove FriProtocolVersionId ([#1510](#1510)) ([6aa51b0](6aa51b0)) * **prover:** Remove redundant LoadingMode ([#1496](#1496)) ([e7583f4](e7583f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
During the genesis, we have some fixed params, and they are changing only during protocol upgrade. In this PR, I've not created an additional file that represents genesis state, but only loaded it from environmental variables.
Why ❔
For system config refactoring we have to split our config system to a few different files and it's the first step to it
Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.