Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eth-sender): adjust the blob tx fees taking into account the current prices #1399

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

montekki
Copy link
Contributor

@montekki montekki commented Mar 11, 2024

What ❔

It has been noted that simply doubling previous prices in case of blob transactions may not be a good enough method to get them actually included. While doubling the prices for replacement transactions is a necessary thing to do it may not be enough, consider a situation where an initial blob gas price has been for any reason estimated to be very low. After a couple of operations of resending the growth of normal fees would quickly outpace the growth of the blob fees:

    "maxFeePerBlobGas": "0x680",
    "maxFeePerGas": "0x6b864500fc0",
    "maxPriorityFeePerGas": "0x2540be4000",

But this does not reflect the current effective blob (or normal 1559) prices onchain. Because at this moment the actual blob prices may be at "maxFeePerBlobGas": "0x54c8a469d" already. So as a solution: take the max of doubled previous prices or the current estimates.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@montekki montekki added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit fea67fb Mar 11, 2024
31 checks passed
@montekki montekki deleted the fvs-fix-blob-gas-price-bumps branch March 11, 2024 13:21
perekopskiy pushed a commit that referenced this pull request Mar 12, 2024
…ent prices (#1399)

## What ❔

It has been noted that simply doubling previous prices in case of blob
transactions may not be a good enough method to get them actually
included. While doubling the prices for replacement transactions is a
_necessary_ thing to do it may not be enough, consider a situation where
an initial blob gas price has been for any reason estimated to be very
low. After a couple of operations of resending the growth of normal fees
would quickly outpace the growth of the blob fees:

```
    "maxFeePerBlobGas": "0x680",
    "maxFeePerGas": "0x6b864500fc0",
    "maxPriorityFeePerGas": "0x2540be4000",
```

But this does not reflect the current effective blob (or normal 1559)
prices onchain. Because at this moment the actual blob prices may be at
`"maxFeePerBlobGas": "0x54c8a469d"` already. So as a solution: take the
`max` of doubled previous prices or the current estimates.

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
- [ ] Spellcheck has been run via `zk spellcheck`.
- [ ] Linkcheck has been run via `zk linkcheck`.

(cherry picked from commit fea67fb)
github-merge-queue bot pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[21.1.0](core-v21.0.0...core-v21.1.0)
(2024-03-13)


### Features

* **api:** Monitor server RPC errors
([#1203](#1203))
([60d1060](60d1060))
* block revert support for consensus component
([#1213](#1213))
([8a3a938](8a3a938))
* **db:** Add Postgres table size metrics
([#1351](#1351))
([63f3ff8](63f3ff8))
* **db:** Serialize events queue as bytes
([#1420](#1420))
([955680b](955680b))
* enabled loading yaml config for the main node
([#1344](#1344))
([0adab9e](0adab9e))
* **en:** Enable Merkle tree client on EN
([#1386](#1386))
([58576d1](58576d1))
* enhance unit test for batch tip
([#1253](#1253))
([ca7d194](ca7d194))
* Moving 1.4.x to use the circuit_api
([#1383](#1383))
([8add2d6](8add2d6))
* **node_framework:** Add timeouts for remaining tasks to avoid hang
outs ([#1354](#1354))
([8108dbd](8108dbd))
* **node-framework:** Add commitment generator layer
([#1402](#1402))
([daa029c](daa029c))
* replacing 1.3.3 test harness with circuit sequencer api
([#1382](#1382))
([a628d56](a628d56))


### Bug Fixes

* **aggregator:** correct order of processing of prove transactions
([#1333](#1333))
([7522d15](7522d15))
* **api:** Fix panics in API server if storage values cache is disabled
([#1370](#1370))
([723232b](723232b))
* **api:** SQL: use = instead of ANY where possible in events-related
queries ([#1346](#1346))
([160b4d4](160b4d4))
* **consistency_checker:** Fix consistency checker for large pubdata
([#1331](#1331))
([d162add](d162add))
* **en:** Fix pending transactions subscription
([#1342](#1342))
([a040001](a040001))
* **eth-sender:** adjust the blob tx fees taking into account the
current prices
([#1399](#1399))
([fea67fb](fea67fb))
* **gas-adjuster:** Do not unwrap in gas-adjuster
([#1400](#1400))
([269812e](269812e))
* **gas-adjuster:** Use `internal_pubdata_pricing_multiplier` for
pubdata price calculation
([#1404](#1404))
([a40c2d0](a40c2d0))


### Performance Improvements

* **db:** Add "contains" clause for get_logs
([#1384](#1384))
([e62ae32](e62ae32))
* **db:** Remove obsolete indexes
([#1376](#1376))
([0afc377](0afc377))


### Reverts

* **db:** Remove "contains" clause for get_logs
([#1384](#1384))
([#1407](#1407))
([1da53f3](1da53f3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants