Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eth_client): Remove support for old pre-boojum verifier #1375

Merged
merged 1 commit into from
Mar 6, 2024
Merged

chore(eth_client): Remove support for old pre-boojum verifier #1375

merged 1 commit into from
Mar 6, 2024

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Mar 6, 2024

What ❔

  • Removing support for pre-boojum verifier (that used a different method to return the verification key)

Why ❔

  • Boojum migration was over 3 months ago
  • removes one dependency on old zkevm_test_harness

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@mm-zk mm-zk requested review from popzxc and perekopskiy March 6, 2024 15:28
@mm-zk mm-zk enabled auto-merge March 6, 2024 15:51
@mm-zk mm-zk added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit b8deee4 Mar 6, 2024
30 checks passed
@mm-zk mm-zk deleted the mmzk0306_remove_preboojum_verifier branch March 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@Deniallugo Deniallugo Deniallugo approved these changes

@popzxc popzxc Awaiting requested review from popzxc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mm-zk @Deniallugo @perekopskiy