Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update snapshots-creator readme #1163

Merged
merged 5 commits into from
Feb 26, 2024
Merged

docs: Update snapshots-creator readme #1163

merged 5 commits into from
Feb 26, 2024

Conversation

pcheremu
Copy link
Contributor

@pcheremu pcheremu commented Feb 21, 2024 •
edited by slowli
Loading

What ❔

Why ❔

Wrong command.

  • extra file

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Documentation comments have been added / updated.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@pcheremu pcheremu requested a review from slowli February 21, 2024 10:02
@pcheremu pcheremu self-assigned this Feb 21, 2024
@slowli slowli changed the title test: fix a typo in zksync-era snapshots-creator docs: Fix typo in zksync-era snapshots-creator Feb 23, 2024
@slowli slowli changed the title docs: Fix typo in zksync-era snapshots-creator docs: Update snapshots-creator readme Feb 23, 2024
@slowli
Copy link
Contributor

slowli commented Feb 23, 2024

Sorry for hijacking the PR; it seemed like an appropriate place to brush up snapshot creator docs.

tomg10
tomg10 previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@tomg10 tomg10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some suggestions for improvements, but otherwise it looks really solid, thanks for doing this work!

core/bin/snapshots_creator/README.md Outdated Show resolved Hide resolved
core/bin/snapshots_creator/README.md Outdated Show resolved Hide resolved
@slowli slowli requested a review from tomg10 February 26, 2024 12:32
@slowli slowli added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 5aa6f6c Feb 26, 2024
18 checks passed
@slowli slowli deleted the QA-674-fix-a-typo-in-zksync-era branch February 26, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanBrodetski RomanBrodetski RomanBrodetski approved these changes

@slowli slowli Awaiting requested review from slowli

@tomg10 tomg10 Awaiting requested review from tomg10

Assignees

@pcheremu pcheremu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcheremu @slowli @RomanBrodetski @tomg10