Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log when tx spends more than 10m in mempool #1057

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

itegulov
Copy link
Contributor

What ❔

Added a logging event when we encounter a tx that spent more than 10m in mempool.

Why ❔

Part of the investigation on why there are spikes in transaction_inclusion_delay metric. Generally inclusion delay tends to be 1-2s, but occasionally spikes up to several hours. Hopefully this log gives us insight into whether there are legitimate transactions that spend a significant amount of time in the pool or the problem is somewhere else.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@RomanBrodetski RomanBrodetski added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 8bdc966 Feb 14, 2024
31 checks passed
@RomanBrodetski RomanBrodetski deleted the daniyar/slow-inclusion-logs branch February 14, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants