-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(node): add basic unit tests for ResourceCollection #1054
Merged
AnastasiiaVashchuk
merged 8 commits into
main
from
anastasiia-tests-for-resource-collection
Feb 16, 2024
Merged
test(node): add basic unit tests for ResourceCollection #1054
AnastasiiaVashchuk
merged 8 commits into
main
from
anastasiia-tests-for-resource-collection
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
reviewed
Feb 14, 2024
popzxc
reviewed
Feb 14, 2024
slowli
reviewed
Feb 16, 2024
popzxc
approved these changes
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2024
AnastasiiaVashchuk
deleted the
anastasiia-tests-for-resource-collection
branch
February 16, 2024 19:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Created 3 unit tests for the
ResourceCollection
component. This PR is second in the range. After, it's expected to add unit test coverage for other components in thenode_framework
.Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.