Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node): add basic unit tests for ResourceCollection #1054

Merged
merged 8 commits into from
Feb 16, 2024

Conversation

AnastasiiaVashchuk
Copy link
Contributor

@AnastasiiaVashchuk AnastasiiaVashchuk commented Feb 13, 2024

What ❔

Created 3 unit tests for the ResourceCollection component. This PR is second in the range. After, it's expected to add unit test coverage for other components in the node_framework.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@AnastasiiaVashchuk AnastasiiaVashchuk added this pull request to the merge queue Feb 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2024
@AnastasiiaVashchuk AnastasiiaVashchuk added this pull request to the merge queue Feb 16, 2024
Merged via the queue into main with commit b4663c3 Feb 16, 2024
30 checks passed
@AnastasiiaVashchuk AnastasiiaVashchuk deleted the anastasiia-tests-for-resource-collection branch February 16, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants