This repository has been archived by the owner on Mar 19, 2022. It is now read-only.
Add --no-sync option to skip syncing and only run Chef #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| librarian_install if config_value(:librarian, true) | ||
| sync_kitchen | ||
| generate_solorb | ||
| if config[:sync] |
There was a problem hiding this comment.
Please use config_value(:sync, true) helper here. Otherwise there are problems with knife bootstrap integration (and maybe with knife solo bootstrap too). Then you can also drop the :default attribute in the option definition to be consistent with other options.
|
@makern Thanks for the pull request! Other than the above comment, I'm fine with this. Mat? Some test would be nice, though. But we can add it ourselves, too. |
|
Changed to use config_value and added a test. |
matschaffer
added a commit
that referenced
this pull request
Sep 4, 2013
Add --no-sync option to skip syncing and only run Chef
|
Thanks! |
|
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option skips preparation and syncing of the kitchen and only runs chef solo on the node.
Our use case for this is to quickly run single recipes on the node via the -o option. Syncing adds a significant delay which is unnecessary in this case since no changes to the kitchen were actually made. Typical runtime reductions for us are from 45s to 17s.
I can see you are working on ssh session caching which is great and will probably reduce overall runtimes a lot but this might still be a useful option.