Librarian-Chef is not run by default when SoloCook/Bootstrap invoked from ruby #221
Conversation
|
Okay, ready for review. |
|
Nice find. Can we file a chef issue and note the number here in hopes that we can take this fix out eventually? |
|
For example: Something like that for whatever project you think is best. |
|
After a lot of chatting, code reading and testing the result was that this is not mixlib-cli bug but more of a Knife feature. The The commit messages should be improved though. |
Add a Chef 10 compatible way of getting correct precedence for command line and configuration file options. Adds correct handling of `false` values to the original example in http://docs.opscode.com/breaking_changes_chef_11.html#knife-configuration-parameter-changes
Librarian-Chef was not run by default when SoloCook/Bootstrap was invoked by for example `knife bootstrap --solo` (from matschaffer#207) or `knife digital_ocean droplet create --solo` (from knife-digital_ocean). The reason is that the `Knife.config` is not loaded by default values when the Knife class is initialized. While this could be fixed in the invoking code it is much cleaner to do moving the default value setting to later in the code. As an extra bonus, by using our `config_value` helper we also make it possible to use `knife[:librarian]` configuration option with Chef 10, too.
|
Mat, I added comments and improved the commit messages. Better? |
Librarian-Chef is not run by default when SoloCook/Bootstrap invoked from ruby
When running e.g.
knife bootstrap --solo(from #207) orknife digital_ocean droplet create --solo(from knife-digital_ocean), librarian-chef is not run asconfig[:librarian]is not set to its default value,true.I'm quite sure this is connected with a Knife/mixlib-cli issue about handling boolean values. But anyway we have to fix it ourselves now.