Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump xtools to 0.1.9 to support go 1.18 #167

Merged
merged 4 commits into from
Mar 18, 2022

Conversation

tprebs
Copy link
Contributor

@tprebs tprebs commented Mar 16, 2022

Resolves #166

@slagiewka
Copy link

You basically beat me by minutes to that.

Why 0.1.9? There's 0.1.10 already that's been released just yesterday. I have successfully tested mock generation with 0.1.10 in my 1.18 project.

@sudo-suhas
Copy link
Collaborator

In addition to what @slagiewka mentioned, could we also please update the CI configuration to test on go 1.17 and 1.18? Relevant file - https://github.com/matryer/moq/blob/v0.2.5/.github/workflows/test.yml#L17-L23

@tprebs
Copy link
Contributor Author

tprebs commented Mar 16, 2022

You basically beat me by minutes to that.

Why 0.1.9? There's 0.1.10 already that's been released just yesterday. I have successfully tested mock generation with 0.1.10 in my 1.18 project.

Ah! I missed the 0.1.10 release yesterday. I have bumped the version.

addition to what @slagiewka mentioned, could we also please update the CI configuration to test on go 1.17 and 1.18? Relevant file

I have added 1.17 and 1.18 to the matrix. Is there any reason we don't run 1.14.x on windows or macos? If we need to exclude mac/windows from 1.14 then it makes more sense to add windows and macos to the matrix and exclude windows and macos for 1.14

This change adds windows and macos to the matrix and excludes 1.14 from running on windows or macos. This matches the original behaviour of the CI build inverting the includes/excludes options
@slagiewka
Copy link

I have added 1.17 and 1.18 to the matrix. Is there any reason we don't run 1.14.x on windows or macos? If we need to exclude mac/windows from 1.14 then it makes more sense to add windows and macos to the matrix and exclude windows and macos for 1.14

I can't read that out from history of this repository so I'm not sure either.

I'm also not sure if that was Suhas' idea here, but maybe this project should now test ONLY against 1.17 and 1.18? That would be in line with Go release policy.

@matryer matryer merged commit 5d3d962 into matryer:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moq fails generating mocks in go 1.18
5 participants