Print version with -version flag #138
Conversation
|
@sudo-suhas @matryer What do you think about exposing the version information via |
|
This is more convenient but we can already see the package version using the |
|
@sudo-suhas I am not sure, what I should think about your answer. Is the usage of Here some context, why I would like to have the |
| @@ -42,6 +43,11 @@ func main() { | |||
| flag.Parse() | |||
| flags.args = flag.Args() | |||
|
|
|||
| if *printVersion { | |||
| fmt.Printf("moq version %s\n", version) | |||
There was a problem hiding this comment.
Perhaps we should just do fmt.Println(version) - allows for programmatic use too?
There was a problem hiding this comment.
As far as I can tell, it is pretty standard for a tool to print not only its version but also its name. I quickly tried with docker, kubectl, terraform and some other tools and all of them provide the name as well. The same holds true also for the go command it self. Therefore I am in favor of keeping the name in there.
That being said, if you insist on having only the version printed, I will update the PR of course.
There was a problem hiding this comment.
OK then - no need to be different for the sake of it.
main.go
Outdated
| @@ -31,6 +31,7 @@ func main() { | |||
| flag.StringVar(&flags.formatter, "fmt", "", "go pretty-printer: gofmt, goimports or noop (default gofmt)") | |||
| flag.BoolVar(&flags.stubImpl, "stub", false, | |||
| "return zero values when no mock implementation is provided, do not panic") | |||
| printVersion := flag.Bool("version", false, "version for moq") | |||
There was a problem hiding this comment.
Unfortunately, there is not really a standard on how the flag is named to print the version information of a tool. I have seen -v, -V, --version, -version and version (for tools with a command style arguments API). Therefore we can choose whatever we like.
Currently we do not have any single letter flag for moq so I suggest to follow the current pattern of named flags and therefore I would keep the longer form of -version.
There was a problem hiding this comment.
OK, pretty compelling arguments.
@matryer The newly introduced var
versionis currently not yet used. This PR does allowmoqto print it's own version.