Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary work in the spaces summary. #123

Closed
wants to merge 2 commits into from

Conversation

clokep
Copy link
Member

@clokep clokep commented Jun 10, 2021

Updates tests for matrix-org/synapse#10085.

@clokep clokep marked this pull request as draft June 10, 2021 11:36
@clokep clokep marked this pull request as ready for review June 11, 2021 13:42
@clokep clokep requested a review from a team June 11, 2021 13:42
@kegsay
Copy link
Member

kegsay commented Jun 25, 2021

Why hasn't this been merged?

@clokep
Copy link
Member Author

clokep commented Jun 25, 2021

Why hasn't this been merged?

Because the corresponding Synapse PR needs changes and hasn't merged, so tests will fail if this is merged.

@clokep clokep changed the title Do not recurse into non-spaces in the spaces summary. Avoid unnecessary work in the spaces summary. Jun 25, 2021
@clokep
Copy link
Member Author

clokep commented Jun 29, 2021

Per the Synapse PR I'm going to re-work this. It did partially land in #138.

@clokep clokep closed this Jun 29, 2021
@clokep clokep deleted the clokep/spaces-simplify branch August 5, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants