Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore better error message on std::runtime_error. #9299

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Restore better error message on std::runtime_error. #9299

merged 1 commit into from
Oct 7, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 6, 2017

attn @Kojoley #9289 (comment)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Kojoley
Kojoley approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@Kojoley Kojoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuLogic QuLogic added this to the 2.1.1 (next bug fix release) milestone Oct 6, 2017
@QuLogic
Copy link
Member

QuLogic commented Oct 6, 2017

Looks like you need to fix the test now.

Kojoley
Kojoley requested changes Oct 6, 2017
View reviewed changes
Copy link
Member

@Kojoley Kojoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. You have to place std::runtime_error handling after std::overflow_error because second inherits first and std::runtime_error catches both.

@anntzer anntzer force-pushed the c++-std-runtime_error branch from d6661f9 to be87212 Compare October 6, 2017 23:35
@anntzer
Copy link
Contributor Author

anntzer commented Oct 6, 2017

fixed

@tacaswell tacaswell merged commit 129403c into matplotlib:master Oct 7, 2017
lumberbot-app bot pushed a commit that referenced this pull request Oct 7, 2017
@tacaswell
Backport PR #9299: Restore better error message on std::runtime_error.
f2bb53c
@lumberbot-app lumberbot-app bot mentioned this pull request Oct 7, 2017
Merged
@anntzer anntzer deleted the c++-std-runtime_error branch October 7, 2017 22:34
tacaswell added a commit that referenced this pull request Oct 8, 2017
@tacaswell
Merge pull request #9310 from matplotlib/auto-backport-of-pr-9299
132200d 
Backport PR #9299 on branch v2.1.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift

@Kojoley Kojoley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @QuLogic @dopplershift @Kojoley @tacaswell