-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates #9291
Doc updates #9291
Conversation
The situation is much better: most GUI toolkits are now pip-installable.
doc/faq/installing_faq.rst
Outdated
@@ -267,14 +178,14 @@ retry the install. If that does not work, then check | |||
Installing via OSX mpkg installer package | |||
----------------------------------------- | |||
|
|||
matplotlib also has a disk image (``.dmg``) installer, which contains a | |||
typical Installer.app package to install matplotlib. You should use binary | |||
Matplotlib also has a disk image (``.dmg``) installer, which contains a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer true, we only do wheels on mac now. Can you remove all references to dmg
files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just edit accordingly? I have close to no idea how things work on OSX, so I can cargo it but I'd rather not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have no idea how macs work, but I do know we do not build a dmg file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just killed the section
|
||
rm -rf build | ||
rm -rf /path/to/site-packages/matplotlib* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be replaced by pip unistall matplotlib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally left it to cover the case of "seriously broken install" but not sure it's worth it -- let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a compelling position, including a reference to pip uninstall matplotlib
someplace would be good though.
4fe9110
to
7490eb5
Compare
doc/faq/installing_faq.rst
Outdated
If you want to be able to follow the development branch as it changes | ||
just replace the last step with:: | ||
|
||
pip install -e . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One gotcha that I've run into is pip
not being installed in the conda environment I'm in, so it uses the default pip
, and installs the development version over the released version in my main conda environment. Not sure where environments fit into this document, but something that could be discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the thing to use python -mpip
throughout, which should make sure pip always works from (and thus, in) the local environment.
I also think that conda now installs pip by default in all envs? (but it's even if it doesn't it's not a problem as long as you use python -mpip
).
Mainly dedent the bullet list, so that it does not appear as a rst blockquote.
Mostly moving away from python3.4 in the examples.
doc/faq/installing_faq.rst
Outdated
your system to install matplotlib. This will guarantee that everything | ||
that is needed for matplotlib will be installed as well. | ||
To install Matplotlib at the system-level we recommend that you use your | ||
distribution's package manager to install Matplotlib. This will guarantee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest drop: "...to install Matplotlib"
doc/faq/installing_faq.rst
Outdated
comes with at least a basic build system. Follow the :ref:`instructions | ||
<install-from-git>` found above for how to build and install matplotlib. | ||
If, for some reason, you can not use the package manager, you may use the | ||
manylinux wheels available on PyPI:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, when I read this I thought that manylinux
was a typo. Put in quotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/pypa/manylinux They never use quotes, I do not think we want to deviate from their notation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit jargon-esque but I'd prefer leaving it as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but how about "...you may use the wheels available from manylinux, available on PyPI"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the manylinux-tagged wheels, available on PyPI
OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further throught I just dropped the "manylinux", as they are the only kind of linux wheels on pypi anyways, and either the reader knows what it means in which case it's obvious the wheels should be manylinux-tagged, or the reader doesn't and that doesn't help him at all.
doc/faq/installing_faq.rst
Outdated
If, for some reason, you can not use the package manager, Linux usually | ||
comes with at least a basic build system. Follow the :ref:`instructions | ||
<install-from-git>` found above for how to build and install matplotlib. | ||
If, for some reason, you can notuse the package manager, you may use the wheels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notuse -> not use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the wrong space :) fixed
DOC: Install instruction updates
backported as 22c088e |
PR Summary
python -c "from pylab import *; plot(); show()" --verbose-helpful
for a minimal error message, which avoids needing to create a separate script file.PR Checklist