Re-organize What's new page #9260

QuLogic · 2017-10-02T04:18:31Z

Add more plots and fix some remaining issues from #9259.

tacaswell · 2017-10-02T04:32:05Z

My rebase is completely un-doable (it organizes the sections), can I just push commits to this branch?

QuLogic · 2017-10-02T04:32:57Z

Sure, go ahead.

This is more of a bug fix than a new feature

anntzer · 2017-10-05T08:18:01Z

doc/users/whats_new.rst

+unit. The default string is " ", which preserves the former
+behavior. Additionally, the separator is now present between the value
+and its unit even in the absence of SI prefix.  There was formerly a
+bug that was causing strings like "3.14V" to be returned instead of


adding bq's here and below will probably help making the difference (extra space) more visible

anntzer · 2017-10-05T08:19:09Z

doc/users/whats_new.rst

+the API required by a class that is to be used as the ``writer`` in the
+:meth:`matplotlib.animation.Animation.save` method. The existing
+:class:`~matplotlib.animation.MovieWriter` class now derives from the new
+abstract base class.

 Validation of line style rcParams
 ---------------------------------


just below, at "strings like ...": would add regular quotes (within the bq's) around "dashed" and "--"

I would lift the subsubsub... headings one level up (perhaps slight rewording) and just drop the "Validation of line style params".

anntzer · 2017-10-05T08:20:39Z

doc/users/whats_new.rst

+pytest
+------
+
+The automated tests have been switched from `nose` to `pytest`.


Perhaps link to the respective projects

anntzer · 2017-10-05T08:26:13Z

the entry about Renderer._uid in the API changes should be removed (killed by #9070)

tacaswell · 2017-10-07T01:39:29Z

@QuLogic @anntzer I think this is ready for another round.

QuLogic

Mostly minor stuff; I can't switch branches at the moment or I would just push the changes.

QuLogic · 2017-10-07T04:08:10Z

doc/api/api_changes.rst

+All functionallity from `mpl_toolkits.axes_grid` can be found in
+either `mpl_toolkits.axes_grid1` or `mpl_toolkits.axisartist`. Axes
+classes from `mpl_toolkits.axes_grid` based on `Axis` from
+`mpl_toolkits.axisartist` can be found in `mpl_toolkits.axisartist`


Should the first one be axes_grid? (Plus add period at end).

functionallity (typo: double l)

Fixed the typo.

I think that this sentence is correct, the Axes sub-classes that used be axis_grid used tools from axisartist, those are now in axisartist

QuLogic · 2017-10-07T06:00:28Z

doc/api/api_changes.rst

+  barh(bottom, width, *, align='center', **kwargs)
+
+despite behaving as the center in both cases. The methods now take ``*args, **kwargs``
+is input and are documented to have the primary signatures of::


QuLogic · 2017-10-07T06:02:45Z

doc/api/api_changes.rst

+requests that a Delaunay triangulation is calculated, which includes
+`matplotlib.pyplot.tricontour`, `matplotlib.pyplot.tricontourf`,
+`matplotlib.pyplot.tripcolor`, `matplotlib.pyplot.triplot`,
+`mlab.griddata` and `mpl_toolkits.mplot3d.plot_trisurf`.


s/mlab/matplotlib.mlab/ (not sure if that will work)
s/mplot3d/mplot3d.axes3d.Axes3D/

QuLogic · 2017-10-07T06:04:08Z

doc/api/api_changes.rst

+
+The ``GraphicsContextBase.get_linestyle`` and
+``GraphicsContextBase.set_linestyle`` methods, which effectively had
+no effect, have been deprecated.


"effectively had no effect" sounds a bit redundant.

QuLogic · 2017-10-07T06:05:41Z

doc/api/api_changes.rst

+``NavigationToolbar2.dynamic_update``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Use :meth:`matplotlib.backend_bases.FigureCanvas.draw_idle` instead.


I think it's FigureCanvasBase, but I'm not sure if that's where one wants to be linking.

QuLogic · 2017-10-07T06:10:18Z

doc/api/api_changes.rst


+Remove the delaunay triangulation code which is now handled by Qhull


Since I can't comment on it, the other instance of qhull should be capitalized to match.

anntzer · 2017-10-07T06:16:37Z

@QuLogic https://git-scm.com/docs/git-worktree is really practical for this case

anntzer · 2017-10-07T19:31:09Z

doc/users/whats_new.rst

+   :include-source:
+   :align: center
+
+   data = {'apples':10, 'oranges':15, 'lemons':5, 'limes':20}


could be PEP8-'ed... (space after colon)

Also (I guess it's kind of too late for this now...) I am really surprised that this does not keep key order (dict implicitly maintain key order on 3.6, but even passing an OrderedDict does not help)

anntzer · 2017-10-07T19:35:35Z

doc/users/whats_new.rst

@@ -67,83 +116,86 @@ angular ticks have been modified to be parallel to the grid line. It may also
 be useful to rotate tick *labels* to match the boundary. Calling
 ``ax.tick_params(rotation='auto')`` will enable new behavior: radial tick
 labels will be parallel to the circular grid line, and angular tick labels will
-be perpendicular to the grid line (i.e., parallel to the outer boundary.)
+be perpendicular to the grid line (i.e., parallel to the outer boundary).


just above: "enable the new behavior"

anntzer · 2017-10-07T19:36:56Z

doc/users/whats_new.rst

-Annotations now use the default arrow style when setting ``arrowprops={}``,
-rather than no arrow (the new behavior actually matches the documentation).
+Alternatively, calling ``savefig`` with ``metadata={'creationDate': None}``
+will omit the timestamp altogether.


This is not consistent with the above docs on metadata which say that "Creator" is the only supported key for (e)ps.

Good catch, this only applies to the pdf backend.

anntzer · 2017-10-07T19:41:01Z

doc/users/whats_new.rst

 ::

    ax.xaxis.set_tick_params(which='both', rotation=90)

+


just below "Shading can now be toggled etc" to be consistent with the style of other headings

anntzer · 2017-10-07T19:42:49Z

doc/users/whats_new.rst

@@ -453,65 +479,141 @@ figure where the subplots will be created. If ``fig`` is ``None`` (default)
 then the method will use the current figure retrieved by
 :func:`~matplotlib.pyplot.gcf`.

-Example
-~~~~~~~
+


this entry could be merged with the addition of figure.subplots? subplot2grid should be double-bq'ed

eh, I like the sorting where they are.

anntzer · 2017-10-07T19:44:37Z

doc/users/whats_new.rst

+Extend ``MATPLOTLIBRC`` behavior
+--------------------------------
+
+The environmental variable can now specify the full file path or path


full file path or directory path? (the sentence is actually not 100% clear although it's not too hard to guess)

anntzer · 2017-10-07T19:47:09Z

doc/api/api_changes.rst



-:meth:`matpltolib.cbook.CallbackRegistry.process` suppresses exceptions by default
+:meth:`matplotlib.cbook.CallbackRegistry.process` suppresses exceptions by default


a bit below "when it receives AN" (not AND)

DOC: Re-organize What's new page

tacaswell · 2017-10-07T22:44:53Z

backported to v2.1.0-doc as a027a02

QuLogic added 2 commits October 2, 2017 00:14

DOC: Correct review issues with what's new page.

a1dc966

DOC: Add more plots to What's new page.

3809204

QuLogic added the Documentation label Oct 2, 2017

QuLogic added this to the 2.1 (next point release) milestone Oct 2, 2017

QuLogic requested a review from tacaswell October 2, 2017 04:27

tacaswell added 23 commits October 1, 2017 22:22

DOC: put in top-level sections

7ef54d8

DOC: move polar plot whats new entry

3e67e1a

DOC: move js animation whats new

cbdb552

DOC: move TransformedPatchPath docs

e5784e3

DOC: move checkbox widget docs

10272f4

DOC: move animation ABC whats new

92f211c

DOC: move AnchoreSizeBar whats new

1f41d33

DOC: move annotation whats new

e7b3fc7

DOC: move mplot3d whats new

e5171ad

DOC: move quiver/barbs whats new

109aaf7

DOC: move hexbin whats new

ec8b1d3

DOC: move the legend whats new

bfa2af3

DOC: move figure clear what new

2947041

DOC: remove avconv whats new

48e2280

This is more of a bug fix than a new feature

DOC: move non-finite axis limits whats new to api changes

c9e5ccc

DOC: move meta-data whats new

2773dae

DOC: move LogFormatterMathtext whats new

0804809

DOC: move patch simplification whats new

4841e9c

DOC: move PercentFormatter whats new

b0c71ca

DOC: move quiverkey whats new

4570155

DOC: move reproducible whats new

f6331fb

DOC: move collection scatter flattening docs to api changes

9690898

DOC: move colorbare reversed whats new

5fb27d1

anntzer reviewed Oct 5, 2017

View reviewed changes

DOC: Fix minor capitalization issues.

7b58314

tacaswell added 5 commits October 6, 2017 19:44

DOC: respond to review comments

6d89c85

DOC: remove all whats new 'Example' sub-headings

8d40a84

DOC: remove api change entry for reverted change

b823496

DOC: merge up and organize api changes

2ee903a

DOC: tweak whats new a bit

d8454ad

DOC: fix ghissue markup

1214252

QuLogic commented Oct 7, 2017

View reviewed changes

DOC: minor review comments

d4f2540

anntzer reviewed Oct 7, 2017

View reviewed changes

tacaswell added 2 commits October 7, 2017 16:17

DOC: minor edits

182430d

DOC: one last double backquote

2ba2bab

tacaswell modified the milestones: 2.1.1 (next bug fix release), 2.1.0-docs Oct 7, 2017

tacaswell merged commit ed96c22 into matplotlib:v2.1.x Oct 7, 2017

tacaswell added a commit that referenced this pull request Oct 7, 2017

Merge pull request #9260 from QuLogic/whatsnew-plots

a027a02

DOC: Re-organize What's new page

QuLogic deleted the whatsnew-plots branch October 7, 2017 23:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-organize What's new page #9260

Re-organize What's new page #9260

QuLogic commented Oct 2, 2017

tacaswell commented Oct 2, 2017

QuLogic commented Oct 2, 2017

anntzer Oct 5, 2017

anntzer Oct 5, 2017 •

edited

Loading

anntzer Oct 5, 2017

anntzer commented Oct 5, 2017 •

edited

Loading

tacaswell commented Oct 7, 2017

QuLogic left a comment

QuLogic Oct 7, 2017

anntzer Oct 7, 2017

tacaswell Oct 7, 2017

QuLogic Oct 7, 2017

QuLogic Oct 7, 2017

QuLogic Oct 7, 2017

QuLogic Oct 7, 2017

QuLogic Oct 7, 2017

anntzer commented Oct 7, 2017

anntzer Oct 7, 2017

anntzer Oct 7, 2017

anntzer Oct 7, 2017

anntzer Oct 7, 2017

tacaswell Oct 7, 2017

anntzer Oct 7, 2017

anntzer Oct 7, 2017 •

edited

Loading

tacaswell Oct 7, 2017

anntzer Oct 7, 2017

anntzer Oct 7, 2017

tacaswell commented Oct 7, 2017


		Remove the delaunay triangulation code which is now handled by Qhull



		:meth:`matpltolib.cbook.CallbackRegistry.process` suppresses exceptions by default
		:meth:`matplotlib.cbook.CallbackRegistry.process` suppresses exceptions by default

Re-organize What's new page #9260

Re-organize What's new page #9260

Conversation

QuLogic commented Oct 2, 2017

tacaswell commented Oct 2, 2017

QuLogic commented Oct 2, 2017

Choose a reason for hiding this comment

anntzer Oct 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anntzer commented Oct 5, 2017 • edited Loading

tacaswell commented Oct 7, 2017

QuLogic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anntzer commented Oct 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anntzer Oct 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tacaswell commented Oct 7, 2017

anntzer Oct 5, 2017 •

edited

Loading

anntzer commented Oct 5, 2017 •

edited

Loading

anntzer Oct 7, 2017 •

edited

Loading