Deprecate QuadContourSet.allsegs, .allkinds, .tcolors, .tlinewidths. #25138
Conversation
|
I strongly suspect that these are widely used by people who want to extract contour computations from Matplotlib. We may have to settle for converting these to just properties (or a longer than normal deprecation cycle). |
|
At least tcolors and tlinewidths should be safe to deprecate. I'd say allsegs and allkinds are better provided by contourpy nowadays, but your remark is well taken and we can at least make the deprecation pending (or even keep them around, if you think that's important, I don't feel very strongly about this). |
|
@ianthomas23 did you have time to comment on this? |
|
Yes, I am 👍 on this. As Tom says the |
|
Sure, done. |
Directly construct the relevant path objects and the collections with the right properties instead of carrying around another copy of the information in raw array form. By having fewer intermediate objects lying around for a long time (as attributes of the QuadContourSet) this makes the logic easier to follow.
|
Sure, done. |
Directly construct the relevant path objects and the collections with the right properties instead of carrying around another copy of the information in raw array form. By having fewer intermediate objects lying around for a long time (as attributes of the QuadContourSet) this makes the logic easier to follow. This also prepares for #25128, but I'd say the change is worthwhile even if we eventually decide not to go that route.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst