-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a note to avoid f-strings in logging #25081
Conversation
@muddi900 Would you also be willing to add an example of how it should be done to the examples? It is not just fstrings, it is any "pre-computed" formatting that is the problem. |
I'll ammend ot on the next day or so. |
Is this complete? Please mark the PR as Ready for review if so. |
You are failing a check in |
added code blocks of examples and changed to pre-computed fixed code-block formatting More gramar and format fixes
Co-authored-by: Jody Klymak <jklymak@gmail.com>
Co-authored-by: Jody Klymak <jklymak@gmail.com>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Docs build has now passed and the section looks like this. |
Thanks @muddi900 ! |
PR Summary
As per #25080, a note has been added to the
contributing.rst
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst