Increase warnings stacklevel
to 2, un-ignore RUFF B028
#4217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
stacklevel
to 2, to point to the caller instead ofwarnings.warn
stacklevel=1
, people might have misunderstood this. It's not "default stacklevel" that is bad, but "default stacklevel as 1" that is not informativeUserWarning
as it's default:_MPResterLegacy
from defaultUserWarning
toFutureWarning
Example
pymatgen/src/pymatgen/ext/matproj_legacy.py
Line 184 in 31f1e1f
Stacklevel 1:
vs
Stacklevel 2: