Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CifParser only warn about primitive default value change to False if not passed to parse_structures explicitly #3505

Merged
merged 1 commit into from
Dec 7, 2023
Merged

CifParser only warn about primitive default value change to False if not passed to parse_structures explicitly #3505

merged 1 commit into from
Dec 7, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Dec 7, 2023

This gets rid of unnecessary warnings where the user or pymatgen internal code is passing in primitive=True or False to CifParser.parse_structures explicitly and so doesn't need to be warned about a change in default value.

@janosh janosh added ux User experience cif Crystallographic information file labels Dec 7, 2023
@janosh janosh changed the title Only warn about change of default value of primitive to False if not passed to parse_structures explicitly CifParser only warn about primitive default value change to False if not passed to parse_structures explicitly Dec 7, 2023
@janosh janosh enabled auto-merge (squash) December 7, 2023 22:23
@janosh janosh merged commit 8082052 into master Dec 7, 2023
21 checks passed
@janosh janosh deleted the less-verbose-cif-warning branch December 7, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cif Crystallographic information file ux User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janosh