Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): Revert change from #5299. #5324

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Conversation

joyzhong
Copy link
Contributor

This is suspected to be preventing screenshot tests from running (e.g. #5323).

Copy link
Contributor

@patrickrodee patrickrodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #5324 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5324      +/-   ##
==========================================
+ Coverage    98.3%   98.57%   +0.26%     
==========================================
  Files         162      162              
  Lines        6311     6311              
  Branches      866      866              
==========================================
+ Hits         6204     6221      +17     
+ Misses        106       89      -17     
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-checkbox/component.ts 96.87% <0%> (+1.04%) ⬆️
packages/mdc-tab/component.ts 98.36% <0%> (+3.27%) ⬆️
packages/mdc-base/component.ts 96.66% <0%> (+3.33%) ⬆️
packages/mdc-ripple/component.ts 100% <0%> (+3.77%) ⬆️
packages/mdc-auto-init/index.ts 96% <0%> (+4%) ⬆️
packages/mdc-ripple/util.ts 88.23% <0%> (+5.88%) ⬆️
packages/mdc-switch/component.ts 98.27% <0%> (+6.89%) ⬆️
packages/mdc-radio/component.ts 95.83% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f110a...0c7c6d8. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 0c7c6d8 vs. master! 💯🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants