fix(fab): Set fab label line-height to normal to center text #5258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
reviewed
Nov 15, 2019
test/screenshot/golden.json
Outdated
| "screenshots": { | ||
| "desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/14/22_24_39_633/spec/mdc-fab/mixins/extended-padding.html.windows_chrome_77.png", | ||
| "desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/15/21_14_53_236/spec/mdc-fab/mixins/extended-padding.html.windows_chrome_77.png", |
There was a problem hiding this comment.
Alignment in previous screenshot looks more correct?
There was a problem hiding this comment.
Its reverting back to the originals. This for some reason only effects windows 10 however this fix of line-height: 1, doesn't break internal clients.
EstebanG23
changed the title
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from |
abhiomkar
approved these changes
Nov 15, 2019
EstebanG23
changed the title
|
All 731 screenshot tests passed for commit eca9627 vs. |
EstebanG23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.