Login required #3214
Merged
Login required #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
Aligner plugin dependecy: https://github.com/matecat/aligner_plugin/pull/209 |
Ostico
force-pushed
the
login-required
branch
from
043fef3 to
4440a85
Compare
- Oauth registerd users can not create account with email and password
- delete not working https://app.asana.com/0/1134617950425092/1208591322128901 - thread_id as null https://app.asana.com/0/1134617950425092/1208591322128901 - is_anonymous not persisted https://app.asana.com/0/1134617950425092/1208550075786134
- Refactory to Languages library and others - Php Typing
riccio82
previously approved these changes
Nov 4, 2024
mauretto78
dismissed
riccio82’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASANA https://app.asana.com/0/1134617950425092/1206421070031165
Documentation
The new auth JWT cookie is called
matecat_login_v6, and has this structure:{ "metadata": { "gplus_picture": "https://lh3.googleusercontent.com/a/xxxxxxxxxx" }, "user": { "email": "domenico@translated.net", "first_name": "Domenico", "has_password": true, "last_name": "Lupinetti", "uid": 166 } }If a not-logged user calls a URL different from the homepage is redirected to this page:
IMPORTANT When a not-logged user calls a URL different from the homepage, a session variable called
wanted_urlis set. Once the use successfully logs in, the session variable is cleared.