Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert LanguageDropdown to a functional component #33701

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Convert LanguageDropdown to a functional component #33701

merged 4 commits into from
Jan 23, 2025

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Jan 23, 2025 •
edited
Loading

In addition, it moves the language detection code in its own file, and properly uses debounce.

@ClearlyClaire ClearlyClaire force-pushed the refactor/language-dropdown-fc branch 2 times, most recently from 133dba9 to 5f87f18 Compare January 23, 2025 11:04
@ClearlyClaire ClearlyClaire force-pushed the refactor/language-dropdown-fc branch from 5f87f18 to 73e2e82 Compare January 23, 2025 11:24
@ClearlyClaire ClearlyClaire marked this pull request as ready for review January 23, 2025 12:05
@ClearlyClaire ClearlyClaire requested a review from a team January 23, 2025 12:05
@Gargron Gargron added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit db14604 Jan 23, 2025
31 checks passed
@Gargron Gargron deleted the refactor/language-dropdown-fc branch January 23, 2025 13:04
@ClearlyClaire ClearlyClaire mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClearlyClaire @Gargron