Fix language detection taking mentions and URLs into account #33700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneiros
approved these changes
Jan 23, 2025
|
It exists in the counter code, I copied it from there. Maybe it would help if it were refactored. |
|
This patch is NOT in v4.4.0-nightly.2025-01-22 , correct ? |
|
But it is in v4.4.0-alpha.2+pr-33702-7bd434c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33694
This should significantly improve detection accuracy.
There is still an issue with the way the function is called: it's debounced, but its result is used synchronously. I'm surprised lodash's debounce even allows you to return a value at all. The correct way is likely to use the debounced function in an effect hook and have it change the state, but it will be more work.