Fix issue with saving empty fields values on profile update #33689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did a quick look through the already merged ones like this. I think there's only one other one (other than what's fixed in this PR) that may be similar, from here - https://github.com/mastodon/mastodon/pull/33675/files#diff-a462fe9e9200b4e371b490db3a05f90005fd1766a207669aae64525a85856318R51 - will confirm that one broke as well and if so do similar spec/fix PR for that one. |
ClearlyClaire
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33688
Some background in #33686 re: the double array approach needed for any "fields for" values we have.
Broken (by me) here - https://github.com/mastodon/mastodon/pull/33673/files#diff-e11d4f7b8ea0ce03ff22a8c5ec8f84f5c17316e72966f1f3ec88aed9c12ffb7eR23 - as part of why I thought was an innocuous auto-correct.
I'll do a once-over on open PRs and the already merged ones like this to see if there has already been any other similar breakage.