Fix notifications from limited users being outright dropped #30559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #29366, it was intended that notifications from limited non-followed users would end up in filtered notifications instead of being outright dropped. However, those notifications were still dropped in an earlier check.
Gargron
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #29366, it was intended that notifications from limited non-followed users would end up in filtered notifications instead of being outright dropped.
However, those notifications were still dropped in an earlier check.
Note that this introduces a pretty significant behavior change that may make limiting servers less effective. I believe that something like #26904 would help, but I'm not too sure where the setting should live, as there's a bit of overlap between notification filtering and that.