Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Delete button state-params fix #537

Closed
wants to merge 2 commits into from
Closed

[RFR] Delete button state-params fix #537

wants to merge 2 commits into from

Conversation

vasiakorobkin
Copy link

Fixes #535

@jpetitcolas
Copy link
Contributor

Good to me. Can you just add a test to prove the bug fix? :)

@fzaninotto
Copy link
Member

No idea why the protractor build failed, I just restarted it.

@vasiakorobkin
Copy link
Author

Wrote end-to-end test to prove the bug fix.

@jpetitcolas
Copy link
Contributor

Needs rebase

@jpetitcolas jpetitcolas changed the title Delete button state-params fix [RFR] Delete button state-params fix Jul 2, 2015
@jpetitcolas
Copy link
Contributor

Can you prefix all your PR ready for review or merge by [RFR]? Would be easier to priorize our reviews. :)

@fzaninotto
Copy link
Member

still needs rebase...

@vasiakorobkin
Copy link
Author

Rebased branch and git push -f'ed it to vasiakorobkin/ng-admin.

@vasiakorobkin vasiakorobkin force-pushed the delete_button_fix branch 2 times, most recently from 4466a38 to c5331a2 Compare July 15, 2015 11:36
@vasiakorobkin vasiakorobkin mentioned this pull request Jul 15, 2015
Merged
@jpetitcolas
Copy link
Contributor

A last rebase to get a green tick from Travis? :)

@vasiakorobkin
Copy link
Author

Rebased. All test has been passed successfully.

@jpetitcolas
Copy link
Contributor

I merged another of your PR. Can you rebase a last time? :)

@vasiakorobkin
Copy link
Author

Done.

@jpetitcolas
Copy link
Contributor

Superseeded by #642.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasiakorobkin @jpetitcolas @fzaninotto