Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the meta title that didn't have the subtitle #65

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Fix the meta title that didn't have the subtitle #65

merged 1 commit into from
Jul 30, 2023

Conversation

sakynasty
Copy link
Contributor

Result before fix

<meta content="Home" name="title">

Result after fix

<meta content="Home - MyWebsite" name="title">

@netlify
Copy link

netlify bot commented Jul 8, 2023 •
edited
Loading

❌ Deploy Preview for accessible-astro failed.

Name Link
🔨 Latest commit 03afbfd
🔍 Latest deploy log https://app.netlify.com/sites/accessible-astro/deploys/64a94ec3f9dcd000089a62d2

@markteekman
Copy link
Owner

Hey @EndLouvy, thanks for submitting the PR, I appreciated your help! 😊 I see that the Netlify deploy preview fails with the following error: [@mdx-js/rollup] The argument 'path' must be a string or Uint8Array without null bytes. Received '\x00@astro-page:src/pages/mdx-page@_@mdx'.

If I run npm run build locally it doesn't produce an error, so I'll have to dive into this when I've got a little more time.

@markteekman markteekman self-assigned this Jul 16, 2023
@markteekman
Copy link
Owner

@3Leelou I think I have found the issue: withastro/astro#7302. Can you run the following command and update the PR? 🙂

npm remove @astrojs/mdx && npm i -D @astrojs/mdx

Thanks! 😊

@sakynasty sakynasty mentioned this pull request Jul 29, 2023
Merged
@sakynasty
Copy link
Contributor Author

It's done.
#67

@sakynasty sakynasty closed this Jul 29, 2023
@markteekman markteekman reopened this Jul 30, 2023
@markteekman markteekman merged commit edaf79c into markteekman:main Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markteekman markteekman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakynasty @markteekman