Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #2870

Merged
merged 1 commit into from
Jul 7, 2023
Merged

fix typo #2870

merged 1 commit into from
Jul 7, 2023

Conversation

alexfauquette
Copy link
Contributor

Marked version:

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

  • Fixes #### (if fixing a known issue; otherwise, describe issue using the following format)

When throwing an error it adds a message with a wrong link to the repository.
Detected because it make test fail since the error message is modified

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 2:31pm

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@UziTech UziTech requested review from styfle and calculuschild July 7, 2023 05:53
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@styfle
Copy link
Member

styfle commented Jul 7, 2023

I'm also wondering if we should remove the period at the end since it might make the link 404. For example:

https://github.com/markedjs/marked.

@UziTech UziTech merged commit e6a7184 into markedjs:master Jul 7, 2023
github-actions bot pushed a commit that referenced this pull request Jul 7, 2023
## [5.1.1](v5.1.0...v5.1.1) (2023-07-07)

### Bug Fixes

* fix typo ([#2870](#2870)) ([e6a7184](e6a7184))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants