Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt users before switching GPU profile using asus_gpu_switch #1

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Prompt users before switching GPU profile using asus_gpu_switch #1

merged 3 commits into from
Oct 3, 2020

Conversation

tashi-iu
Copy link

@tashi-iu tashi-iu commented Oct 3, 2020 •
edited
Loading

While running the asus_gpu_switch service, it can be quite confusing for new users to understand what profile they are in and whether they should switch to their desired GPU. Hence this PR adds a prompt before making the switch, telling the user what GPU is currently being used and a simple y/n input to determine if the GPU profile should switch or not.

marcolaux
marcolaux reviewed Oct 3, 2020
View reviewed changes
Copy link
Owner

@marcolaux marcolaux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your interest and contributing - very appreciated!

I agree with you when one does not use the Gnome Shell extension that indicates the current state like so with AMD:
grafik

Could you make it so, that no response is needed? Perhaps with an option like "-y".
Because I still want to switch the GPU with the Gnome Shell extension without a terminal prompt. The Shell extension starts the service asusgpuswitch that just calls asus_gpu_switch.

@tashi-iu
Copy link
Author

tashi-iu commented Oct 3, 2020 •
edited
Loading

Thanks! I have updated it to accept a -y flag. If you start with systemctl start asusgpuswitch.service, then no prompt will be shown. Running the script directly with sudo asus_gpu_switch however, will prompt the user. Or they can do sudo asus_gpu_switch -y 😄

@marcolaux
Copy link
Owner

Great, thank you :)

@marcolaux marcolaux merged commit 7f5f1c1 into marcolaux:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcolaux marcolaux marcolaux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tashi-iu @marcolaux